monotone

monotone Commit Details

Date:2010-11-27 00:37:48 (8 years 6 months ago)
Author:Thomas Keller
Branch:net.venge.monotone
Commit:3784c72f3fbb028c9d08593574179d311efb507b
Parents: 3b415f32eb83376f005aac30faeb1f1fa2314623
Message:* network/connection_info.cc (set_raw_uri): bail out early if uri.host is empty

* tests/netsync_badhost_gives_nice_error/__driver__.lua: expand the existing
test case accordingly
* NEWS: note the fix
Changes:
MNEWS (1 diff)
Mnetwork/connection_info.cc (1 diff)
Mtests/netsync_badhost_gives_nice_error/__driver__.lua (1 diff)

File differences

NEWS
2727
2828
2929
30
30
3131
32
33
34
35
3236
3337
3438
- 'automate remote' and 'automate remote_stdio' now use
a given database given by an alias to read, store and validate
a remote server's key fingerprint (fixes monotone issue 95)
a remote server's key fingerprint (fixes monotone issue 95)
- monotone gives a proper error message now if a netsync URI
with the 'mtn' scheme misses the required host part
(fixes monotone issue 110)
Internal
network/connection_info.cc
278278
279279
280280
281
282
283
281284
282285
283286
if (uri.scheme.empty())
uri.scheme = "mtn";
E(uri.scheme == "mtn" && !uri.host.empty(), origin::user,
F("a non-empty hostname is expected for the 'mtn' uri scheme"));
var_key server_include(var_domain("server-include"),
var_name(uri.resource(), origin::user));
tests/netsync_badhost_gives_nice_error/__driver__.lua
11
22
33
4
4
5
6
7
8
mtn_setup()
check(mtn("pull", "nosuchhost__blahblah__asdvasoih.com", "some.pattern"), 1, false, false)
check(mtn("pull", "nosuchhost__blahblah__asdvasoih.com", "some.pattern"), 1, false, true)
check(qgrep("name resolution failure for nosuchhost__blahblah__asdvasoih.com", "stderr"))
check(mtn("pull", "mtn:localhost?*"), 1, false, true)
check(qgrep("a non-empty hostname is expected for the 'mtn' uri scheme", "stderr"))

Archive Download the corresponding diff file

Branches

Tags

Quick Links:     www.monotone.ca    -     Downloads    -     Documentation    -     Wiki    -     Code Forge    -     Build Status