monotone

Issue 173: Test failure in diff_patch_drop with newer patch(1)

Reported by Thomas Keller, May 22, 2011

Steps to reproduce the problem:
-------------------------------

1. Install patch-2.6.1.116 or newer
2. Run the diff_patch_drop test


Expected result:
----------------

Successful run.


Actual results:
---------------

Test failure in line 39.


Output of `mtn version --full`:
-------------------------------

mtn-1.0, openSUSE:Factory


I contacted Andreas Gr├╝nbacher (hacker on patch(1) and openSUSE 
packager):

"[...] Previously (at least up until patch 2.6.1.81), when 
patch received a complete file deletion as input (target path 
/dev/null), it not only deleted the file, but also the empty 
directory it resided in. Now with the version oS has deployed on 
Factory (2.6.1.116), patch only seems to remove the file, but not 
the directory.

Is this something that is now expected, maybe even a result of

<
http://git.savannah.gnu.org/cgit/patch.git/commit/?id=685a78b6052f4df
6eac6d625a545cfb54a6ac0e1>

?
"

and I'm awaiting his answer. The easiest fix for this problem is 
obviously to remove the check in line 39 altogether.

Created: 6 years 6 months ago by Thomas Keller

Status: New

Owner: Thomas Keller

Labels:
Type:Incorrect Behavior
Priority:Low

Quick Links:     www.monotone.ca    -     Downloads    -     Documentation    -     Wiki    -     Code Forge    -     Build Status