monotone

Issue 224: Monotone does not compile with LUA 5.2(.2)

Reported by Olaf Seibert, Oct 11, 2013

Steps to reproduce the problem:
-------------------------------

1. I tried to build the pkgsrc-packaged version of monotone-1.0, 
with lua-5.2.2 installed.
2. The build failed.

Expected result:
----------------

A clean build.

Actual results:
---------------

There are several issues:

Monotone uses several #defines which don't exist any more: 
LUA_GLOBALSINDEX, LUAI_MAXCSTACK, lua_strlen.

luaext_platform.cc uses another #define which does not exist any 
more: LUA_ENVIRONINDEX.
Looking for a quick fix it turned out that the function where it is 
used is trying something intimate with internal lua functions from 
liolib.c. However that stuff has been completely changed between lua 
5.1 and 5.2. So a quick fix for somebody not intimate friends with 
lua *and* monotone is out of the question.

This is a serious portability problem!

Output of `mtn version --full`:
-------------------------------

Comment 1 by Thomas Moschny, Oct 11, 2013

This is a known issue. Code on the main net.venge.monotone branch 
already works with Lua 5.2.

You now have several options:
- use nvm head version
- wait for Monotone 1.1, to be released within short time
- use a patch

If you are looking for patches, see e.g. 
http://pkgs.fedoraproject.org/cgit/monotone.git/tree/ .

Comment 2 by Olaf Seibert, Oct 11, 2013

Thanks! It looks like the patches are for now the way to go in 
pkgsrc.

Comment 3 by Markus Wanner, Apr 22, 2014

As pointed out by Thomas, already, this has been fixed in 
net.venge.monotone and will appear in the next release, which is due 
real soon now (tm).
Status: Fixed

Created: 2 years 8 months ago by Olaf Seibert

Updated: 2 years 2 months ago

Status: Fixed

Followed by: 2 persons

Labels:
Type:Defect
Priority:Medium

Quick Links:     www.monotone.ca    -     Downloads    -     Documentation    -     Wiki    -     Code Forge    -     Build Status