monotone

Issue 70: "mtn status" prints garbled characters.

Reported by Unknown User, Dec 22, 2007

(This entry was imported from the savannah tracker, original 
location: https://savannah.nongnu.org/bugs/index.php?21870)

Dear the development team of monotone,

Not in the C locale, "mtn status" shows garbled characters.

I guess, in the function "revision_summary" of the file 
cmd_ws_commit.cc, you create the instance of utf8 class with the 
constructor, but the argument string is encoded in user's locale, 
not in UTF-8. Because F() returns what gettext() returns.

static void
revision_summary(revision_t const & rev, branch_name const & 
branch, utf8 & summary)
{
  string out;
...
  out += (F("Current branch: %s") % branch).str() += '\n';
...
    summary = utf8(out);
}

I attach a sample fix.

Regards,
Tomohisa Tanaka (Tomohisa.Tanaka@gmail.com)


monotone version:
-----------------
monotone 0.38 (base revision: 
c1757f6cde49bddd77c82580059105bc470145b2)
Running on          : FreeBSD 6.2-RELEASE-p4 FreeBSD 6.2-RELEASE-p4 
#0: Thu Apr 26 17:40:53 UTC 2007     
root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386
C++ compiler        : GNU C++ version 3.4.6 [FreeBSD] 20060305
C++ standard library: GNU libstdc++ version 20060311
Boost version       : 1_34_1
Changes since base revision:
format_version "1"

new_manifest [085f4d04a0bbbc06b44cf6194ca9c2079f924cdd]

old_revision [c1757f6cde49bddd77c82580059105bc470145b2]

  Generated from data cached in the distribution;
  further changes may have been made.

Comment 1 by Unknown User, Dec 22, 2007

added attachment monotone-status-sample-fix.patch

Comment 2 by Thomas Keller, Jan 7, 2009

The issue was further discussed here, but not yet fixed:

http://thread.gmane.org/gmane.comp.version-control.monotone.devel/148
84/focus=14884

Created: 8 years 7 months ago by Unknown User

Updated: 7 years 6 months ago

Status: New

Labels:
Type:Incorrect Behavior
Component:Charset Handling
Priority:Medium

Quick Links:     www.monotone.ca    -     Downloads    -     Documentation    -     Wiki    -     Code Forge    -     Build Status